search

neos / Neos.EventSourcing

A library for Event Sourcing and CQRS for Flow projects.
MIT License
44 stars 30 forks source link

JobQueueEventPublisher iterates over event class names more often than intended #283

Closed kdambekalns closed 3 years ago

kdambekalns commented 3 years ago

This code

https://github.com/neos/Neos.EventSourcing/blob/c6c5b49f472b42bfbd55f320f5680dda8db29360/Classes/EventPublisher/JobQueueEventPublisher.php#L88-L91

does not what it is suppsoed to do, since no event class names are ever marked as processed later in the code. A simple

$processedEventClassNames[$eventClassName] = true;

added after that block would help.

kdambekalns commented 3 years ago

@bwaidelich Do you agree?

bwaidelich commented 3 years ago

Whoopsi. Good catch, @kdambekalns !

bwaidelich commented 3 years ago

=> #284 (untested)