search

neos / flow-development-collection

The unified repository containing the Flow core packages, used for Flow development.
https://flow.neos.io/
MIT License
139 stars 188 forks source link

Documentation Update needed #621

Closed neos-bot closed 4 years ago

neos-bot commented 10 years ago

Jira issue originally created by user tpei:

Ever since version 2.0 Flow won't persist changes automatically, therefore the code snippet at http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinitiveGuide/PartII/Controller.html requires a $this->persistenceManager->persistAll(); to be added to the indexAction of the SetupController

Jira-URL: https://jira.neos.io/browse/FLOW-55

RafaelKa commented 8 years ago

I think small note with one sentence and refernce to "Safe request methods are read-only" on some place of "Create Action" section in TheDefinitiveGuide/PartII/Controller.rst is better.

Alternativelly this issue can be closed, because indexAction() is a safe one...

sorenmalling commented 4 years ago

The persisting is done only on POST, PUT, DELETE, PATCH as stated in the documentation

https://flowframework.readthedocs.io/en/stable/TheDefinitiveGuide/PartIII/Persistence.html?highlight=persistall#safe-request-methods-are-read-only

There is no persisting going on in the indexAction in the mentioned documentation (from original issue) so this issue will be closed :)