search

neos / form-builder

Flow Form Framework integration into Neos CMS
GNU General Public License v3.0
18 stars 30 forks source link

error while deactivating further pages #135

Closed adrian-cerdeira closed 3 months ago

adrian-cerdeira commented 3 months ago

Hello When I want to deactivate (because I don't need it) furtherPages in yaml:

childNodes:
 'furtherPages': null

It gives me then this error:

Bildschirmfoto 2024-07-02 um 13 48 03

When I check this in the line of code it breaks here, because furtherPages is null. $output = $output . $this->wrapNode($node->getNode('furtherPages'), '', $fusionPath . '/furtherPages');

Is it possible to make this a feature in the future?

bwaidelich commented 3 months ago

Thanks for reporting. Would you be willing to create a PR that checks for that null case? That would greatly increase the chances for this feature to make it into the core :)

adrian-cerdeira commented 3 months ago

@bwaidelich I would love to create a PR but I don't have permission to create a branch. Can you give me access?

bwaidelich commented 3 months ago

You can just fork the repository, see https://docs.github.com/articles/creating-a-pull-request

adrian-cerdeira commented 3 months ago

@bwaidelich Thanks, PR is created.

bwaidelich commented 3 months ago

@adrian-cerdeira Thanks for your contribution, it's included in version 2.3.5