search

neos / form

Flow Form Framework
https://flow-form-framework.readthedocs.org/en/latest/
MIT License
15 stars 36 forks source link

BUGFIX: Fix RenderValuesViewHelper PHP 8+ compatibility #165

Closed patriceckhart closed 2 years ago

patriceckhart commented 2 years ago

Adjusts the RenderValuesViewHelper such that it checks whether the element value to render is an object, before trying to map it. This resolves an Illegal offset type exception that was thrown for \DateTime objects with PHP > 7.4

bwaidelich commented 2 years ago

@patriceckhart Thanks a lot for this contribution. If you could add some (minimal) description and a type prefix (BUGFIX: ...) to this PR, I could merge it and trigger a patch release

patriceckhart commented 2 years ago

@bwaidelich Done.

patriceckhart commented 2 years ago

@bwaidelich Strange that it works with PHP 7.4 on Neos 7.4.

bwaidelich commented 2 years ago

I took the freedom to adjust the subject & description slightly and replace the deprecated \DateTime occurrences.

But I just realized that this should have been against branch 5.3 instead of master – I'll down-merge it