search

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 221 forks source link

BUG: Fusion autoInclude and manual include lead to recursion when used together #3985

Open kdambekalns opened 1 year ago

kdambekalns commented 1 year ago

Is there an existing issue for this?

Current Behavior

Having a site package that is also autoIncluded via settings leads to recursion that is not detected and breaks rendering.

Parsing goes into an infinite loop that only ends when PHP is terminated (memory exhaustion or manual intervention).

Possibly related: When disabling autoInclude and manually including the root fusion file of one site package (containing include: **/*.fusion) from another site package, this seems to lead to recursion, too.

Expected Behavior

Recursion is detected and an error message informs the user about what is going wrong.

Steps To Reproduce

If that doesn't trigger the recursion, @breadlesscode hopefully can provide something to reproduce it…

Environment

- Flow: 8.2.x
- Neos: 8.2.x
- PHP:

Probably 8.0 and up are affected, it used to work in 7.x I am told…

Anything else?

No response

mhsdesign commented 1 year ago

Thanks for reporting ;) Ill try to fix it with https://github.com/neos/neos-development-collection/pull/3839

mhsdesign commented 1 year ago

I could not reproduce it. I agree that there is an error see https://github.com/neos/neos-development-collection/issues/3835 and im working on a fix for that.

But i just created 3 sites and sitepackages who are all referenced in the autoinclude (double checked it) and the fist visited site works (then the known problem: #3835)

but no

Parsing goes into an infinite loop that only ends when PHP is terminated (memory exhaustion or manual intervention).

(tested on 8.0 and 8.2)

mhsdesign commented 1 year ago

oh this got auto closed.

is the issue fixed with neos-8.3-dev? @kdambekalns @breadlesscode ?

i couldn't reproduce it ...

kdambekalns commented 1 year ago

I don't know, maybe @breadlesscode can confirm.

breadlesscode commented 1 year ago

Sorry, cant reproduce it atm. Really busy at work 😞

Edit: Will check that in a few weeks.

mhsdesign commented 1 year ago

Okay thanks ;)

(Will be fixed/released with neos 8.3)