META 9.0 cleanup todos; commented code; commented/skipped tests; check php inline docs;

[mhsdesign]

• cleanup todos. There were many todo comments added from 8.3 to 9.0. Some of those are probably already resolved and were just early thoughts but i saw here and there a few that probably need to be addressed. Either way we should reduce the todos - especially if they are outdated.

  • https://github.com/neos/neos-development-collection/issues/4470
  • improve https://github.com/neos/neos-development-collection/blob/5e485ee74a4cdc5d5d81a1e48eaa57fa24d41a65/Neos.Neos/Classes/Controller/Frontend/NodeController.php#L364

• cleanup dangerous assert expressions. Instead of using php docs var tag /** @var we started using phps assert. But we should make sure that we never assert anything that could possibly really fail, as for this cases we should throw a real exception.

• cleanup commented code. Some implementations are partially commented out as they havent been adjusted to work with Neos 9.0 yet and to avoid linting errors. We should make sure we know about all places and fix them or remove them.

• cleanup commented/skipped tests. We started to write tests in behat. The old Neos.Neos functional tests (also regarding fusion prototypes) should be migrated to behat. Not necessarily 1 to 1 but to cover all important features / usecases.

• cleanup unused new code

  • https://github.com/neos/neos-development-collection/blob/88cb1fd2a1ad3bb0e012b3594a7a16a0d7e2848a/Neos.ContentRepository.Core/Classes/Dimension/ContentDimension.php#L99
  • https://github.com/neos/neos-development-collection/blob/a2a04475c7acdff9ca184ff1abe4c1e8c40829da/Neos.ContentRepository.Core/Classes/Feature/NodeAggregateCommandHandler.php#L186
  • https://github.com/neos/neos-development-collection/blob/7edbbdcfea4b46f733dce687dc9aff8946c563bd/Neos.ContentRepository.Core/Classes/Feature/Common/ConstraintChecks.php#L191
  • stuff inside NodeVariationInternals

• check php inline docs. References via {@see fooo} should link to existent places. I just found out that our main read model - the beloved node - had long unnoticed misleading documentation, because the docs were originally written for methods and not properties. (Maybe leverage phpstan to check @see annotations?

  • https://github.com/neos/neos-development-collection/blob/71e64ed8fdd4c2b1ae9b771d2b887c7521be995c/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php#L44-L52

• cleanup dead doc generation

  • https://github.com/neos/neos-development-collection/pull/4862

• cleanup dead policy yaml regex

• cleanup dead imports https://github.com/neos/neos-development-collection/pull/4747

• everything around NodeReferenceSnapshot is marked wip and todo? So does copying nodes work if they have references? https://github.com/neos/neos-development-collection/blob/0fe7b5ac74ccb74822512cd04cafb0e310d958cd/Neos.ContentRepository.Core/Classes/Feature/NodeDuplication/Dto/NodeReferenceSnapshot.php#L21

• todos that are not marked as todo but just via ? and a newline \n like https://github.com/neos/neos-development-collection/blob/3a7aa79e857e9d78e4c0ade1017dee643335f09d/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/VisibilityConstraints.php#L20

• check for Todo string in exception messages and enhance details or create a dedicated exception subclass.

• unify license headers https://github.com/neos/neos-development-collection/issues/5138

• Change workspace seems untested https://github.com/neos/neos-development-collection/pull/5184#issuecomment-2252330504

[mhsdesign]

For example the code says here

https://github.com/neos/neos-development-collection/blame/9.0/Neos.ContentRepository.Core/Classes/Feature/NodeCreation/Command/CreateNodeAggregateWithNode.php#L64

"CREATE METHODS FÜR ALLE COMMANDS"

should we do this actually?

-> solved via https://github.com/neos/neos-development-collection/pull/4489 ✅

[mhsdesign]

Whut isn this? https://github.com/neos/neos-development-collection/blob/73bf90f9348a1c560b61a8f112f8d0bc80942925/Neos.Neos/Classes/EventLog/Integrations/ContentRepositoryIntegrationService.php

[mhsdesign]

Another good one: https://github.com/neos/neos-development-collection/blob/53a0d132722c51ef600e97bfc256b408856640d8/Neos.Neos/Classes/Domain/Model/Site.php#L158-L159 ha you wish

[mhsdesign]

@pKallert noted that we match unused methods

Unneeded permissions from deprecated methods: Is there a way to do an automated check? Old permissions @Paula Kallert