search

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 221 forks source link

!!! BUGFIX: Fix schema of hierarchy relation table #5009

Closed mhsdesign closed 2 months ago

mhsdesign commented 2 months ago

Partially reverts #4790 that changed the indexes of the cr_<crid>_p_graph_hierarchyrelation table.

Note that this needs a ./flow cr:setup and ./flow cr:projectionreplay --projection contentGraph

mhsdesign commented 2 months ago

performance tests:

9.0: super sloooow

reverting just the primary key adjustments of line 68: https://github.com/neos/neos-development-collection/pull/4790#discussion_r1577800888

4.42s user 1.86s system 16% cpu 37.674 total
4.75s user 1.97s system 17% cpu 38.736 total
5.37s user 2.18s system 18% cpu 40.325 total

reverting https://github.com/neos/neos-development-collection/pull/4790 fully

4.42s user 1.83s system 16% cpu 38.628 total
4.40s user 1.84s system 16% cpu 37.995 total
4.51s user 1.86s system 16% cpu 38.764 total
bwaidelich commented 2 months ago

@mhsdesign can you remove the draft status?

mhsdesign commented 2 months ago

Sure i just want to require @kitsunet's review on this one :)

mhsdesign commented 2 months ago

As per @kitsunet's message via slack

Yeah merge the removal and then let’s check soonish what an actual primary key could look like and why this isn’t

i consider this approved

Followup ticket: https://github.com/neos/neos-development-collection/issues/5011