4790 Followup, rethink the optimisations

[mhsdesign]

In #4790 some optimisations were done.

A part of the change caused a critical bug in the beta8 and slowed down performance enormous while replaying ContentStreamWasForked events.

This part will be reverted via https://github.com/neos/neos-development-collection/pull/5009 as a hotfix.

But some questions are still open:

• [ ] is #4790 really a performance optimisation with noticeable effect when replaying? Bastian and me tested #5009 and compared that to a full revert of #4790 and found evidence (investigated on 20k events with two language dimension values). On the contrary Bastian thinks it might even slow down slightly.
• [ ] Why was the bug mentioned in slack not discovered by any test?

  Cannot update node with copy on write since no anchor point could be resolved for node cd70f561-2952-40c8-9775-8250db07d66b in content stream d79cacd3-ee68-421a-bbca-f5e56a0348ce

• [ ] if the primary key as proposed by christian is apparently wrong, what else is it if not a compound key of ['childnodeanchor', 'contentstreamid', 'dimensionspacepointhash', 'parentnodeanchor']

[kitsunet]

IMHO replay is not even a valid performance test case, because it's ultimately uninteresting if that takes a bit longer or not. I certainly didn't really test for that. It's more important that the projections are compact and read queries are fast (and workspace creation obvs)

if the primary key as proposed by christian is apparently wrong

Or do we have an error in the projection that just didn't manifest so far because we didn't have this key? Because I really do not know how this should be able to exist twice.

[kitsunet]

To add some discussion points, as now I got started thinking about all of this, supposedly this is the query to get the parent to a specific child (identified by contentstream, dimensions and aggregate id)

        return $this->createQueryBuilder()
            ->select('pn.*, ch.name, ch.subtreetags')
            ->from($this->contentGraphTableNames->node(), 'pn')
            ->innerJoin('pn', $this->contentGraphTableNames->hierachyRelation(), 'ph', 'ph.parentnodeanchor = pn.relationanchorpoint')
            ->innerJoin('pn', $this->contentGraphTableNames->node(), 'cn', 'cn.relationanchorpoint = ph.childnodeanchor')
            ->innerJoin('pn', $this->contentGraphTableNames->hierachyRelation(), 'ch', 'ch.childnodeanchor = pn.relationanchorpoint')
            ->where('cn.nodeaggregateid = :childNodeAggregateId')->setParameter('childNodeAggregateId', $childNodeAggregateId->value)
            ->andWhere('ph.contentstreamid = :contentStreamId')->setParameter('contentStreamId', $contentStreamId->value)
            ->andWhere('ch.contentstreamid = :contentStreamId')
            ->andWhere('ph.dimensionspacepointhash = :dimensionSpacePointHash')->setParameter('dimensionSpacePointHash', $dimensionSpacePoint->hash)
            ->andWhere('ch.dimensionspacepointhash = :dimensionSpacePointHash');

And now I wonder, why do we join hierachy twice here? It should be the same edge just looked at from different sides, it cannot be two separate edges between parent and child, or do I miss something big here?

[kitsunet]

Another thing, I didn't see this before but this exists: \Neos\ContentGraph\DoctrineDbalAdapter\Domain\Projection\HierarchyRelation::getDatabaseId and uhhh, this suggests it shoudl be unique as well as it is used in place of an identifier within the class for update queries....?

[kitsunet]

aaand this also assumes the combination is unique: \Neos\ContentGraph\DoctrineDbalAdapter\Domain\Repository\ProjectionContentGraph::findIngoingHierarchyRelationsForNode

[kitsunet]

I think it would be helpful to figure out what query exactly fails with the primary key applied (or stop replay right after the problematic version without the key) so we can see what hierachy is created, I more an dmore suspect we might actually create invalid data there?

[nezaniel]

I'm a bit concerned as well that the replay didn't work with the imho proper index. To me that looks rather like a broken event stream than an issue with the projection. I'd really like to see the hierarchy relations to the failing node aggregate and how they came to be.

The hierarchy relation double-check was introduced years ago at a time when the graph projection was maybe less mature than now, we could have a look at that. Especially with all the new test cases implemented since then.

As for performance, I agree with @kitsunet; we optimize for read performance here. I'd be up for serious performance testing in the postgres adapter later on, maybe we then can backport some of our insights to the general dbal adapter in a later version.

[kitsunet]

I have this primary key currently on my system again and it's fine... It doesn't have much benefit though, so I guess we can just skip it for now and reevaluate this later on. Fact remains if this uniqueness is violated something is wrong in the uderlaying data.

[mhsdesign]

Jup and i still cannot replay his event stream in the latest beta. So they might just be corrupted.

[mhsdesign]

Okay as a "hi" from the future.

I attempted to revert https://github.com/neos/neos-development-collection/pull/5009 again and see if the primary key still causes trouble in the projected from earlier

->setPrimaryKey(['childnodeanchor', 'contentstreamid', 'dimensionspacepointhash', 'parentnodeanchor'])

And - probably due to pruning a lot of useless event streams - it works. So if it makes a difference we can reintroduce this? :) Though i did mention with the primary key a tremendous slowdown during replay before - not anymore - but maybe only because its less events now?

EDIT: Hold my horses, adding the above primary key does work for the one projected it failed earlier the year but it fails now on another one i tested:

Exception while catching up to sequence number 45255: Failed to insert hierarchy relations: An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1-092cd743-55dc-4c1e-b62c-9e4543704740-2a5a7710c2ce5ef3d812da...' for key 'PRIMARY'