Open mhsdesign opened 4 months ago
older notes just for reference :)
getIdentity
https://github.com/neos/neos-development-collection/pull/4678further todos from christian an me:
ContentGraph::getSubgraph()
~ (with runtime cache in the ContentGraph
– the same workspace will resolve to the same CS ID in one request, maybe reset runtime cache via markStale()
)ContentGraph::find*
queries to use workspaceName instead of contentStreamId~ (IMO it's totally fine to join the workspaceName <-> cs id table here for those queries. Alternatively we could add a dedicated lookup + runtime cache)Afterwards we have to find out whether there are places that need to be able to override the workspace name -> cs id mapping for tests or CR constraints. If so we could either:
ContentGraph::getSubgraphInternal()
– but that would be dangerous because it is part of the public interface (even if marked internal)ContentsubgraphFactoryInterface
that can be used via CR service$contentGraph->dangerousSetContentStreamIdForWorkspaceNameFooBar(...)
Followup for https://github.com/neos/neos-development-collection/pull/5028
CommandHandlingDependencies::getWorkspaceFinder
(andgetContentStreamFinder
)ContentGraphFinder::getByWorkspaceNameAndContentStreamId
by passing the content graph factory directly to theCommandHandlingDependencies
ContentGraphFinder
thing or rename it?iExpectTheSubgraphProjectionToConsistOfExactlyNodes
is a dub ofiExpectTheGraphProjectionToConsistOfExactlyNodes
getContentGraph
nullable or throwing exception? -> the expectation is that the workspace does exist and it would just make the code using it more complex. Also there is likely no fallback option available meaning we will mostly throw an exception again, so this might as well be the default.Things for https://github.com/neos/neos-development-collection/pull/5042