neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 220 forks source link

Define ContentGraph memory cache flushing #5039

Open mhsdesign opened 1 month ago

mhsdesign commented 1 month ago

good point, this is a dealbreaker IMO – probably it makes sense to call this something else (e.g. resetRuntimeCaches) and then reset the inMemoryCache (we should not disable it).

The main goal of this change was not to expose all those nasty internals such that we can refactor more easily. In fact inMemoryCache is now only public because it is still used by the nasty code of the frontend controller (which I plan to clean up)

But we should make sure that:

$subGraph->find*(...);
$contentRepository->handle(...);
$subGraph->find*(...);

behaves as expected, i.e. the second subgraph interaction contains the changes.

Lets see if the tests fail – and if they don't we should add scenarios that reflect the above!

_Originally posted by @bwaidelich in https://github.com/neos/neos-development-collection/pull/5028#discussion_r1593535508_

mhsdesign commented 1 month ago

points from todays meeting

        * long running process where other process changes content repository? How to flush
            * manually call markstale??
        * flush in same process when mark stale
        * disable vs flush confusion?