neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 221 forks source link

TASK: Workspace based tests #5040

Closed nezaniel closed 4 months ago

nezaniel commented 4 months ago

Resolves partially #5034

This adjusts the test suite to operate directly on workspace names instead of content stream IDs

Upgrade instructions

Review instructions

Most changes are purely search/replace, with a few exceptions:

https://github.com/neos/neos-development-collection/compare/5034-workspaceBasedTests?expand=1#diff-2e50430c540d541e90b7b2233957a44a9d2fb4e8240d3de077bbc93192d3cc65R306

Here we check the timestamps in the new content stream instead of the closed one as before, thus the change in payload, as discussed with @bwaidelich in Slack

https://github.com/neos/neos-development-collection/compare/5034-workspaceBasedTests?expand=1#diff-a3b3697e967ca37986b11850c79037b9594ba0742f7cf2da5a140f31f85701a3L81

Has been refactored to use the given content stream id and the matching workspace instead of the unrelated current workspace name.

Also, we cannot remove content stream checks as we have test cases for content stream forking without workspaces being involved. Also, structure adjustments don't use workspaces, so we have to again check content streams

Checklist

nezaniel commented 4 months ago

I guess it's just too much for Github... it should lead to ProjectedNodeTrait::iExpectANodeIdentifiedByXToExistInTheContentGraph

mhsdesign commented 4 months ago

Did a reverse string replace and reviewed that diff fully just for fun. Can confirm that only things have been touched that should have and the time stamp thing. Will merge this now as this blocks progress ;)