neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 221 forks source link

BUG: Neos9-beta10 old `NodeAggregateWasMoved` cannot be normalized #5056

Closed mhsdesign closed 4 months ago

mhsdesign commented 4 months ago

The change https://github.com/neos/neos-development-collection/pull/4993 caused a regression in that this event cannot be normalized:

{
  "contentStreamId": "90bcfbf8-c444-48f8-9911-ba0954ac795a",
  "nodeAggregateId": "30ef3082-e37f-4346-83cf-45ed0249381f",
  "nodeMoveMappings": [
    {
      "movedNodeOrigin": {
        "language": "pl"
      },
      "newLocations": [
        {
          "coveredDimensionSpacePoint": {
            "language": "pl"
          },
          "newSucceedingSibling": {
            "nodeAggregateId": "7db24575-1227-4c7c-87ff-7aaa98532a94",
            "originDimensionSpacePoint": {
              "language": "pl"
            },
            "parentNodeAggregateId": "6b6e1251-4346-494f-ac56-526a30a5741d",
            "parentOriginDimensionSpacePoint": {
              "language": "pl"
            }
          }
        }
      ]
    }
  ]
}

Neos\ContentRepository\Core\SharedModel\Node\NodeAggregateId::fromString(): Argument #1 ($value) must be of type string, array given, called in Neos/Neos.ContentRepository.Core/Classes/Feature/NodeMove/Event/NodeAggregateWasMoved.php on line 98

mhsdesign commented 4 months ago

Note to self: We most definitely need to cover these things with tests as well, either simple unit or behat (maybe have some "old" event stream that is still supported)

Also todo improve the error which event this comes from so it says:

Failed to instantiate Domainevent for event with type "NodeAggregateWasMoved" and id "de62e850-6564-41c1-a2f2-4347816298c1"