TASK: Remove explicit deprecated command blocking

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.

https://www.neos.io/

GNU General Public License v3.0

260 stars 220 forks source link

Closed mhsdesign closed 1 month ago

mhsdesign commented 1 month ago

Following things have been adjusted:

Removal of the step: The graph projection is fully up to date
- remove lastCommandOrEventResult
Removal of the step: The documenturipath projection is up to date
Remove CommandResult::block in php

Upgrade instructions

Review instructions

Checklist

[ ] Code follows the PSR-2 coding style
[ ] Tests have been created, run and adjusted as needed
[ ] The PR is created against the lowest maintained branch
[ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
[ ] Reviewer - The first section explains the change briefly for change-logs
[ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

kitsunet commented 1 month ago

Use injected Connection in tests instead of DoctrineDbalClient

This is super unrelated :/

bwaidelich commented 1 month ago

This is super unrelated :/

yes. I agree - and it was somehow unrelated in my large PR, too.. It would be cool if we could split that from this PR, but...

mhsdesign commented 1 month ago

yes thats the only part that bums me as well but @bwaidelich started it in his pr and this is a partial git checkout -- from it ...

fyi. I did a review myself and can confirm that only the stuff that needed to has been removed from the .feature files.

mhsdesign commented 1 month ago

aggreed did a little wizardy by manually editing a patch (tell me if there is a better way ^^) and reverted it 1to1. Should be imo part of https://github.com/neos/neos-development-collection/pull/5005

kitsunet commented 1 month ago

DbalClientInterface seems missing according to the failings?

mhsdesign commented 1 month ago

Missing import and no phpstan coverage :D