neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 220 forks source link

WIP: TAKS: Improve node address serialisation #5067

Closed mhsdesign closed 1 month ago

mhsdesign commented 1 month ago

Followup to https://github.com/neos/neos-development-collection/pull/4892 with the intent to optimise the NodeAddress uri serialisation.

Currently using base64 + json produces bigger output for dsps and also the default case (empty) is not particular pretty. Additionally base64 as used currently is actually not safe due the = padding. Which could produce problems when used as query parameter.

See also https://github.com/neos/neos-development-collection/issues/4564#issuecomment-1999514362 for the discussion

Upgrade instructions

Review instructions

Checklist

kitsunet commented 1 month ago

Suggestion https://github.com/neos/neos-development-collection/issues/5072

mhsdesign commented 1 month ago

As discussed in https://github.com/neos/neos-development-collection/issues/5072 we want to stick with json