!!! TASK: Deprecate setting NodeNames via cr commands

[mhsdesign]

Resolves: https://github.com/neos/neos-development-collection/issues/5050

Upgrade instructions

The parameter $nodeName is not accepted anymore in the main factory via CreateNodeAggregateWithNode::create and CopyNodesRecursively.

Please adjust your code to use the additional with*-er instead.

$command = CreateNodeAggregateWithNode::create(...);

if ($nodeName) {
    $command = $command->withNodeName($nodeName);
}

If you set their value previously simply to null, you can just omit setting this argument.

Review instructions

Checklist

• [ ] Code follows the PSR-2 coding style
• [ ] Tests have been created, run and adjusted as needed
• [ ] The PR is created against the lowest maintained branch
• [ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• [ ] Reviewer - The first section explains the change briefly for change-logs
• [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[nezaniel]

I definitively prefer named arguments over withers...

[mhsdesign]

alternatively we can put succeedingSiblingNodeAggregateId at the end (after initialProperties) or just omit this change from this change ... it was just a thought which came up here: https://github.com/neos/neos-development-collection/pull/5082#discussion_r1607733756

i think we definitely want to mark setting the nodeName as deprecated as it is infact a deprecated feature.

[nezaniel]

imho node names become a deprecated feature once Neos starts resolving sites by id, not name. I'd agree to make nodename a wither, but not succeeding sibling id since this is a common use case (I'm literally using this at this moment in the starship)

[mhsdesign]

Okay fair enough, in that case i was maybe too quick ... anyways i reverted the change to introduce withSucceedingSiblingNodeAggregateId. This part is about the node names ;)