TASK: Cleanup and stabilize `Neos.ContentGraph.DoctrineDbalAdapter`

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.

https://www.neos.io/

GNU General Public License v3.0

260 stars 220 forks source link

Closed bwaidelich closed 1 month ago

bwaidelich commented 1 month ago

Cleans up and stabilizes the implementation of the Neos.ContentGraph.DoctrineDbalAdapter implementation by...

replacing inline SQL strings with Heredoc for better readability and IDE support
properly handling and declaring Exceptions
synchronizing some internal namings
moving all when*() methods from Traits to the main DoctrineDbalContentGraphProjection
fixing method/field visibility (no protected in final classes)

kitsunet commented 1 month ago

I like what I am seeing so far 😆 When the reminaing convos are fixed this is good to go IMHO. Thanks!

bwaidelich commented 1 month ago

the files with the large diffs are beyond me today…

I can fully comprehend.. Thanks for trying – and hopefully those changes make future diffs easier to read :)