search

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 220 forks source link

BUGFIX: Fix composer manifest #5095

Closed bwaidelich closed 1 month ago

bwaidelich commented 1 month ago
bwaidelich commented 1 month ago

phew.. I don't understand what's happening here.

mhsdesign commented 1 month ago

Hä how should https://github.com/neos/neos-development-collection/pull/5036 have broken test:functional and why should it be removed. Tbh i dont understand a thing ^^ Will have to investigate myself too. And i dont use composer test :D (and neither does ci)

mhsdesign commented 1 month ago

Judging by your comment here

@mhsdesign I'm surprised that this didn't break CI because the test:functional script now dies with

Cannot open file "Neos.ContentRepository.Core/Tests/Functional".

when running composer test locally

i assume that we have to remove the Neos.ContentRepository.Core in the dev distribution or build essentials. Just anywhere in our spaghetti soup.

kitsunet commented 1 month ago

the storage client is still required (see l 29 in composer.json)

kitsunet commented 1 month ago

https://github.com/neos/neos-development-collection/blob/9.0/Neos.ContentRepositoryRegistry/composer.json#L18 and merged composer.json

bwaidelich commented 1 month ago

Hä how should https://github.com/neos/neos-development-collection/pull/5036 have broken test:functional

@mhsdesign because test:functional used to trigger phpunit with an argument Neos.ContentRepository.Core/Tests/Functional – and that fails if that path does not exist

the storage client is still required

@kitsunet ah, right.. The issue was the empty provides array in the template – that led to a composer error:

  "./composer.json" does not match the expected JSON schema:  
   - provide : Array value found, but an object is required

I fixed it now by removing the empty array from the template and make the Neos.ContentGraph.DoctrineDbalAdapter a provider (which is correct IMO).

Does that make sense?

mhsdesign commented 1 month ago

yeah missed that we actually reference Neos.ContentRepository.Core/Tests/Functional ... even checked the build essentials and co but forget to comment.

So post merge +1