neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 220 forks source link

TASK: Unify naming of contentRepositoryIdentifier to contentRepository in ESCR CLI commands #5115

Closed crydotsnake closed 4 weeks ago

crydotsnake commented 1 month ago

Review instructions

This is a todo part of: #4772

This takes care of unifying and changing the contentRepositoryIdentifier to contentRepository for the input in our CLI commands for the ESCR.

Adjust CommandControllers:

SubprocessProjectionCatchUpCommandController has not been adjusted yet (see my comment below)

Checklist

mhsdesign commented 1 month ago

❤️ thank you for talking this problem

dlubitz commented 1 month ago

Thank you!

mhsdesign commented 3 weeks ago

fyi i also reviewed that we dont use the old argument name in ci and stuff ... the only usage i found was here https://github.com/neos/neos-development-collection/blob/7977bac7dc7fb8e4bf1f7accb5668d5e005fa69b/Neos.ContentRepositoryRegistry/Classes/Factory/ProjectionCatchUpTrigger/SubprocessProjectionCatchUpTrigger.php#L37 but this is dead code and will be removed soon ;)