!!! TASK: Move workspace module to separate package

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.

https://www.neos.io/

GNU General Public License v3.0

260 stars 221 forks source link

!!! TASK: Move workspace module to separate package #5118

Closed ahaeslich closed 4 months ago

ahaeslich commented 4 months ago

Tasks

[x] Create new package named "Neos.Workspace.Ui"
[x] Move settings
[x] Move translations
[x] Only minimal adjustments in controller code
[x] Use singular for controller name
[ ] Register package in neos distribution
[x] Create core migration to adjust existing privilege usages ❓

Upgrade instructions

Add neos/workspace-ui as dependency.

Review instructions

Checklist

[ ] Code follows the PSR-2 coding style
[ ] Tests have been created, run and adjusted as needed
[x] The PR is created against the lowest maintained branch
[ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
[ ] Reviewer - The first section explains the change briefly for change-logs
[ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

mhsdesign commented 3 months ago

Aaaand if we have a list for creating new packages we should also add that we need to adjust to include it in phpstan as well.

Btw did you migrate all the translation files by hand oO soooo much work :O or can weblate do this as well? xD

Sebobo commented 3 months ago

Did it by hand, while you were talking during the sprint 😉

kdambekalns commented 3 months ago

Did it by hand, while you were talking during the sprint 😉

I think it would have been enough to do it in the en files, Weblate should clean things up as needed then…

dlubitz commented 1 week ago

It seems, there are references to the moved translations, which where not updated and are not working anymore.

E.g: https://github.com/neos/neos-development-collection/blob/9.0/Neos.Media.Browser/Resources/Private/Templates/Usage/RelatedNodes.html#L127-L127

Are there any plans to find and change them?

(I fixed them in the RelatedNodes.html, but I guess there are more in other templates)

ahaeslich commented 1 week ago

Thx for finding the issue.

Are there any plans to find and change them?

It seems we have to check more views for this labels.

dlubitz commented 1 week ago

We might re-think which package owns the translations. E.g. the translation of "Workspace" should not be owned by a workspace package. As this is a general translation in Neos. Otherwise we would need to have a dependency to the workspace package in each package where we use the "Workspace" translation.

dlubitz commented 1 week ago

E.g. The Media Browser... By using the translation keys of Workspace.Ui I made the Media Browser package dependent on the Workspace UI package. Which shouldn't be.