neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 218 forks source link

TASK: Optimize afx rendering by disabling sorting on generated `Neos.Fusion:Join` #5123

Closed mficzel closed 3 weeks ago

mficzel commented 4 weeks ago

The sorting requires a little compute power that we can spare. In the result this will reduce rendering time of presentational afx about 10%.

Upgrade instructions

This would cause problems when @position is used in afx to reorder children. This makes not much sense imho so i would consider this probably non breaky.

Checklist

mficzel commented 4 weeks ago

Not sure if this is worth the effort as it would indeed break some use cases.

This change would allow to start working in the following optimizations:

However while this would indeed improve the fusion performance the effort is quite high and we figured out that the bottleneck during rendering currently is not fusion but eel.

mficzel commented 3 weeks ago

Close this for now