search

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 218 forks source link

BUGFIX: show FlashMessage if asset is still in use in media browser inspector and no error #5133

Open KommunikativCh opened 3 weeks ago

KommunikativCh commented 3 weeks ago

Bugfix for #5085 no error if asset still in use and show flashmessage solution set class neos-notification-container as id

In media browser inspector if assets are deleted wich are still used no FlashMessage was showed and on second delete an error pages was showed.

Solution: In Neos.Media:Browser/Resources/Private/Layouts/Default.html change class neos-notification-container to id neos-notification-container, because Notification.js / Toast is searching for id neos-notification-container to insert FlashMessages.

` 

            <f:render section="Content"/>
        </div>
        <aside class="neos-media-aside">`

related: #5085

Checklist

  • [ ] Code follows the PSR-2 coding style
  • [ ] Tests have been created, run and adjusted as needed
  • [x] The PR is created against the lowest maintained branch
  • [x] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • [ ] Reviewer - The first section explains the change briefly for change-logs
  • [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions
KommunikativCh commented 1 week ago

During testing it was noticed that the message text was always displayed in the default language. this has now been fixed with the commit.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.