TASK: Provide alternative for `NodeDiscriminator::fromNode` that doesnt use Nodes content stream

neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.

https://www.neos.io/

GNU General Public License v3.0

260 stars 218 forks source link

TASK: Provide alternative for `NodeDiscriminator::fromNode` that doesnt use Nodes content stream #5144

Closed mhsdesign closed 16 hours ago

mhsdesign commented 2 weeks ago

Related #5034 and #5043

Upgrade instructions

Review instructions

Checklist

[ ] Code follows the PSR-2 coding style
[ ] Tests have been created, run and adjusted as needed
[ ] The PR is created against the lowest maintained branch
[ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
[ ] Reviewer - The first section explains the change briefly for change-logs
[ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

mhsdesign commented 2 weeks ago

I think this is a valid way, question is do we want to do it like this for the rest of the usages of NodeDiscriminator::fromNode as well (ca 8)?

cc @nezaniel

mhsdesign commented 2 weeks ago

Okay so i tried 3 different ways of achieving the goal (not to use $node->subgraphIdentity->contentStreamId) and im now kinda happy with the last attempt of introducing a ContentStreamAwareNode (+ builder) for the tests.

Horray 🥳

mhsdesign commented 16 hours ago

Closing in favour of https://github.com/neos/neos-development-collection/pull/5169