neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 218 forks source link

TASK: Use collection value objects in content graph instead of `iterable` #5157

Open mhsdesign opened 1 week ago

mhsdesign commented 1 week ago

Solves partially: https://github.com/neos/neos-development-collection/issues/5102

In the content graph we have some methods returning NodeAggregates and others iterable<NodeAggregate> while it seems like it, the iterable is also not lazy and yielded but fetches all nodes eagerly so there is no performance / memory gain.

This change is not really breaking, as NodeAggregates implement \IteratorAggregate and thus foreaching or calling iterator_to_array on the results will not make a difference.

Though this change should happen before a final release :D

Upgrade instructions

Review instructions

Checklist