neos / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
https://www.neos.io/
GNU General Public License v3.0
260 stars 218 forks source link

BUGFIX: Fix content cache for discard, revert #5083 for now #5163

Closed mhsdesign closed 1 week ago

mhsdesign commented 1 week ago

Resolves: https://github.com/neos/neos-development-collection/issues/5150

Readds the contentstreamid to node cache entry identifier (effectively reverting the changes in #5083 conceptional)

The change was taken too lightly and the whole content cache flushing depends on the assumption that after publishing or discard, everything will be rendered. With this knowledge and the added test we should be able to refactor it correctly in the feature without introducing a regression again.

The regression #5150 was attempted to be fixed in several ways https://github.com/neos/neos-development-collection/pull/5155 or https://github.com/neos/neos-development-collection/pull/5160 but it seems we need more brain power to finish this. For the meantime this pr restores the behaviour again and lets us continue development in the Neos Ui with green e2e tests.

Upgrade instructions

Review instructions

Checklist

kitsunet commented 1 week ago

Unfortunate, but yeah probably one of those hard problems.

mhsdesign commented 1 week ago

The Neos Ui e2e tests also work locally with this change again.