TASK: 5034 fully completely workspace aware behat tests

mhsdesign commented 6 days ago

Resolves: #5034 Replaces: https://github.com/neos/neos-development-collection/pull/5167 Replaces: https://github.com/neos/neos-development-collection/pull/5144

Remove CRTestSuiteRuntimeVariables::$currentContentStreamId
gets rid of the final usages of I am in content stream in the behat tests.
Additionally our hack \Neos\ContentRepository\Core\ContentGraphFinder::getByWorkspaceNameAndContentStreamId is now no longer in use by the tests and can be changed to be not at all exposed.
Removes deprecated usage $node->subgraphIdentity->contentStreamId in \Neos\ContentRepository\TestSuite\Behavior\...\NodeDiscriminator::fromNode

Upgrade instructions

Review instructions

Checklist

[ ] Code follows the PSR-2 coding style
[ ] Tests have been created, run and adjusted as needed
[ ] The PR is created against the lowest maintained branch
[ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
[ ] Reviewer - The first section explains the change briefly for change-logs
[ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

kitsunet commented 6 days ago

I think I like this direction

nezaniel commented 2 days ago

Imho If the tests for ForkContentStream are removed, the command itself must be removed as well. Otherwise we have untested code paths and I really dislike that.

mhsdesign commented 2 days ago

We dont remove the tests for ForkContentStream, we just test it from a higher perspective. Effectively the test is the same. But we could surely just inline the forking logic in the CreateWorkspace command i guess as we wont be needing an api way to just fork a content stream. However if we decide to go down that road i would like to keep that change separate as it will likely also span the CreateContentStream and further commands that are now obsolete standalone.

mhsdesign commented 19 hours ago

Okay i did declare the content stream commands as internal:

@internal implementation detail, please use the higher level workspace commands instead.

do you agree as well on going down this road now @nezaniel?

neos / neos-development-collection

TASK: 5034 fully completely workspace aware behat tests #5169