BUGFIX: Filter sites to import from

neos / neos-setup

Custom neos/setup steps and configuration for Neos CMS

GNU General Public License v3.0

1 stars 3 forks source link

BUGFIX: Filter sites to import from #9

Closed Sebobo closed 1 year ago

Sebobo commented 2 years ago

This error appeared due to an parameter change in https://github.com/neos/flow-development-collection/commit/b0713d4cb705836df2861c30b4ae937e3bde5a0a

Resolves: #8

kitsunet commented 2 years ago

What basti said, I guess I would revert the original change for now just to avoid splitting between versions. and reintroduce it as breaking change with 7.0

kdambekalns commented 2 years ago

This package is compatible with Neos ^5.0 || ^7.0 || ^8.0 and the signature changed only for 7.3.8+

Thou shalt not be using setup with old Neos versions these days…

Sebobo commented 2 years ago

Good catch, we should be more careful when we change the signature of API methods – and we shouldn't do that in a patchlevel release anyways

But I wonder: This package is compatible with Neos ^5.0 || ^7.0 || ^8.0 and the signature changed only for 7.3.8+

Oh thx! I didn't notice that dependency. Hmmm, shouldn't it be fine then to bump the dependency in this PR to ^7.3.8 || ^8.0?