search

neos / neos-ui

Neos CMS UI written in ReactJS with Immutable data structures.
GNU General Public License v3.0
265 stars 135 forks source link

Support for smart quotes in RTE #2345

Open danielkestler opened 5 years ago

danielkestler commented 5 years ago

Description

Typographically correct quotation marks (e.g. „...“, »...«) are not automatically set (smart quotes) when entering them with the inch symbol (").

Steps to Reproduce

Enter a sentence like "this is my text".

Expected behavior

It should read „this is my text“, depending on the language of the current node dimension.

Actual behavior

It reads "this is my text" as entered.

Affected Versions

Neos: all

UI: all

dimaip commented 5 years ago

Would be cool, but also really hard to implement properly! Would have to be a CKE5 plugin, obviously.

danielkestler commented 5 years ago

Hoped that maybe there already is a plugin out there...? It‘s not an uncommon requirement I guess 😉

danielkestler commented 5 years ago

There's a plugin for CKEditor 4, perhaps we can adapt the functionality? https://ckeditor.com/cke4/addon/autocorrect

dimaip commented 5 years ago

We could, but that would be a complete re-write from scratch, as CKE4 and 5 are completely different editors having nothing in common. The least we could do is to leave a feature request in their repo...

iseries commented 5 years ago

What if the editor don't want auto correction? It't a nice feature but I think that some people do not want Neos to change inserted characters by default.

dimaip commented 5 years ago

No problem making it configurable. Could even start off as a separate package.

mhsdesign commented 2 years ago

ckeditor 5 features auto formatting as plugin which we can use https://discuss.neos.io/t/new-ckeditor-features-to-integrate/4810/3?u=marc