search

neos / neos-ui

Neos CMS UI written in ReactJS with Immutable data structures.
GNU General Public License v3.0
264 stars 131 forks source link

BUG: React Warning "Please update the following components: ReactCrop3" #3309

Open grebaldi opened 1 year ago

grebaldi commented 1 year ago

Description

When using the Image Cropper, React issues a warning:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFEcomponentWillReceiveProps to suppress this warning in non-strict mode. In > React 17.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: ReactCrop3

Steps to Reproduce

  1. Try cropping an image
  2. See warning in the console

Expected behavior

There should be no warning.

Actual behavior

image

Affected Versions

Neos: 8.2

UI: 8.3 (current dev branch)

grebaldi commented 1 year ago

Update: I was unable to reproduce this on 7.3, 8.0, 8.1 and 8.2. It is reproducible on 8.3, so it must be due to a recent change.