neos / neos-ui

Neos CMS UI written in ReactJS with Immutable data structures.
GNU General Public License v3.0
265 stars 135 forks source link

BUG: Nodecreation position icons not shown #3616

Open mhsdesign opened 1 year ago

mhsdesign commented 1 year ago

Description

image

expected:

image

Regression since using custom icons: https://github.com/neos/neos-ui/pull/3423

We currently just concatenate the uri on client side which doesnt respect cases where one uses resources in the cloud. The bigger scope of the issue is described here: https://github.com/neos/neos-ui/issues/2092

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Affected Versions

Neos:

UI:

You can get this information by running composer show or using the package management module within Neos. The UI version can also be found inside the left sidebar after version 1.0.3.

Sebobo commented 1 year ago

Why do we use separate icons with their own uris for this and not the iconset?

Sebobo commented 1 year ago

Just for this issue we could also embed the SVGs to skip the requests.

ahaeslich commented 9 months ago

Okay now we have two use cases: