search

neos / neos-ui

Neos CMS UI written in ReactJS with Immutable data structures.
GNU General Public License v3.0
264 stars 136 forks source link

BUG: Remove leading and tailing whitespace in LinkInput #3859

Open markusguenther opened 1 week ago

markusguenther commented 1 week ago

Description

Editors often had the case that they copied links from an Excel list and then pasted them into e.g. LinkEditor fields.

If the people do not notice that a space at the end of the URL was copied or a tab at the beginning, the link immediately leads to a 404. 

Steps to Reproduce

https://github.com/user-attachments/assets/06052606-d2d8-4383-bd24-1b0c6d57e989

Expected behavior

The links is trimmed so that we do not save the leading or tailing whitespace.

Affected Versions

Neos: 8.3 (but guess it happens also in earlier versions)

UI: 8.3

Jai-Marothiya commented 6 days ago

Hello @markusguenther,

I am interested in solving this bug and I believed I can fix it. Please assign this issue to me.

markusguenther commented 6 days ago

Thank you for taking on this issue. However, we already have an open pull request for this. You are welcome to review it.

Jai-Marothiya commented 6 days ago

Cool, can you assign me 1-2 relevant issues similar to this or may be different on which I can work?

Jai-Marothiya commented 6 days ago

I reviewed your PR and it looks good.