search

neos / neos-ui

Neos CMS UI written in ReactJS with Immutable data structures.
GNU General Public License v3.0
265 stars 135 forks source link

Add extension point for overriding element Rendering in Node Trees #867

Open skurfuerst opened 7 years ago

skurfuerst commented 7 years ago

<- must-have for 1.0.0

One of our core feature sponsors needs a way to manipulate the rendering of the TreeNodes; i.e. he wants to display additional icons based on custom property values.

In order to support that, we at least need to put the tree node React elements in the registry, so they can be overridden from the outside.

dimaip commented 7 years ago

Hmm I like the idea, but at the same time we should be careful about creating such ad-hoc APIs as we'd need to maintain them. Can we maybe declare it as an unplanned extensibility?

skurfuerst commented 7 years ago

yes, for sure, I'd definitely declare it as unplanned extensibility!

dimaip commented 6 years ago

@skurfuerst can we close it now since you have this fancy extensibility thing in place?

mstruebing commented 6 years ago

Not exactly, you'd have to override the whole tree, at the current state it's not possible to only override the tree elements. I've experienced this while developing this: https://github.com/sitegeist/Sitegeist.TrafficLights

UI-specific code: https://github.com/sitegeist/Sitegeist.TrafficLights/tree/master/Resources/Private/TrafficLights/src

dimaip commented 6 years ago

Ok, let's reopen then