search

neos / rector

Neos Rector Recipes for code migrations
6 stars 4 forks source link

TASK: Adjust migration for `renderingMode.isEdit` #22

Closed mficzel closed 1 year ago

mficzel commented 1 year ago

the migration previously adjusted the code to a now deprecated eel helper. In pr https://github.com/neos/neos-development-collection/pull/4505 the userInterfaceMode is introduced as global fusionValue which made an adjustment in the rector necessary.

(node|documentNode|site).context.inBackend is now migrated to renderingMode.isEdit (node|documentNode|site).context.live is now migrated to !renderingMode.isEdit

In cases where it cannot be determined wether a node is affected by the context operation a comment is added as before.

Relates: https://github.com/neos/neos-development-collection/issues/4086

mficzel commented 1 year ago

Will be ready to review after https://github.com/neos/neos-development-collection/pull/4505

bwaidelich commented 1 year ago

@mficzel just checking whether only the description is wrong: we did agree to remove the isLive property right?

mficzel commented 1 year ago

@bwaidelich right Description is outdated live becomes !isEdit