search

neos / rector

Neos Rector Recipes for code migrations
6 stars 4 forks source link

FEATURE: Rewrite NodeType::getName() #26

Closed dlubitz closed 1 year ago

dlubitz commented 1 year ago

Rector migration for NodeType::getName removal

https://github.com/neos/neos-development-collection/issues/4560

PHP $nodeType->getName() to $nodeType->name->value

Fusion ${node.nodeType.name} to ${node.nodeTypeName.value}

Fixes partly #25

ahaeslich commented 1 year ago

Also I wonder: Do all our rector migrations add a "TODO 9.0 migration" prefix?

I remember a conversiation that we add this prefix if we can't be sure that the migration would be correct. E.g. if we can't be sure if it is a node.

dlubitz commented 1 year ago

@bwaidelich As Anke says, it's on all places where the migrator should have have a look and might need to change something manually. @ahaeslich You are absolutly right. I added them.