BUG: Rector migration for usage of `node.parent` doesn't work

neos / rector

Neos Rector Recipes for code migrations

6 stars 4 forks source link

Closed ahaeslich closed 1 year ago

ahaeslich commented 1 year ago

It will generate comments for lines that are using flow query operations like parent() or parents()
The comment says You may need to rewrite "VARIABLE.parent" to Neos.NodeAccess.findParent(VARIABLE). But I found no matching eel helper.

dlubitz commented 1 year ago

Good catch! Maybe someone of the experts can tell us what the correct replacement is? /cc @mhsdesign @mficzel @bwaidelich

mficzel commented 1 year ago

As I see from my cellphone flowQuery “parent”|”parents” is implemented. This migration might be not needed at all.

dlubitz commented 1 year ago

It's actually not FlowQuery it was the removed getter of the Node.

mficzel commented 1 year ago

How about converting that to q(node).parent().get(0)

kdambekalns commented 1 year ago

It still warns about q(node).parents()…