TASK: Remove "internal" node properties

neos / rector

Neos Rector Recipes for code migrations

6 stars 4 forks source link

Closed kitsunet closed 7 months ago

kitsunet commented 8 months ago

Adds rector migrations for common "underscore" internal property access on nodes.

Related: #neos-development-collection/4208

kitsunet commented 8 months ago

Mmm, these test failures seem unrelated?

ahaeslich commented 8 months ago

Mmm, these test failures seem unrelated?

Sure are. I stumbled upon them with my PR and as I investigated the last successful run on main was with this commit: https://github.com/neos/rector/commit/d3cc877a2ba816db303c13dfe8c84ef4f5ff1242

ahaeslich commented 8 months ago

Upon further investigation using phpstan/phpstan in version 1.10.13 the tests are green again on main.

Next step in this 🐰 hole: why can't we relax the requirement?