Add generic rule for adding comments to fusion prototype usage

neos / rector

Neos Rector Recipes for code migrations

6 stars 4 forks source link

Add generic rule for adding comments to fusion prototype usage #52

Closed dlubitz closed 7 months ago

dlubitz commented 7 months ago

Add rule for adding comments to used Prototypes.
Replace dedicated Neos.Neos:PrimaryContent rule with generic rule
Add comments for Neos.Fusion:Attributes

kdambekalns commented 6 months ago

Ok, so this PR broke neos/rector, at least for me:

$ bin/rector --dry-run

 [ERROR] Expected an instance of this class or to this class among its parents
         "Rector\Core\Contract\Rector\RectorInterface". Got:
         "Neos\Rector\Generic\ValueObject\FusionPrototypeNameAddComment" in
         /…/Packages/Libraries/neos/rector/src/../config/set/contentrepository-90.php
         (which is being imported from "/…/rector.php").

If I go back one commit, it works.

kitsunet commented 6 months ago

@kdambekalns with the hard pinned rector version of the package?