Open mhsdesign opened 4 months ago
@dlubitz i have the feeling that the migrations cant be possible as clean as suggested and will likely look like having an obsolete step in between (fetching the nodeType first)
- $node->getNodeType()->getName();
+ $nodeTypeManager->getNodeType($node->nodeTypeName)->name->value;
- $node->getNodeType()->getTypeOfAutoCreatedChildNode(NodeName::fromString('name'));
+ $nodeTypeManager->getTypeOfTetheredNode($nodeTypeManager->getNodeType($node->nodeTypeName)->name, NodeName::fromString('name'));
... or we can have a rector rule to normalize $nodeTypeManager->getNodeType($node->nodeTypeName)->name
to $node->nodeTypeName
😂
https://github.com/neos/neos-development-collection/pull/4906#issuecomment-2035430771
Todo these rector migration would need to be adjusted so they dont pass the
$nodeType
to the methods, but$nodeType->name
:
- NodeTypeGetAutoCreatedChildNodesRector
- NodeTypeGetTypeOfAutoCreatedChildNodeRector
- NodeTypeAllowsGrandchildNodeTypeRector
Following code should be migrated:
For fusion:
Node::getNodeType
removal (https://github.com/neos/neos-development-collection/pull/5021)(existing migration)
NodeType::tetheredNodeTypeDefinitions
change (https://github.com/neos/neos-development-collection/pull/4906)These rector migration would need to be adjusted so they dont pass the
$nodeType
to the methods, but$nodeType->name
: