search

neos / rector

Neos Rector Recipes for code migrations
6 stars 4 forks source link

BUGFIX: Remove rule for rewriting Node::getNodeType to Node::nodeType #92

Closed dlubitz closed 2 weeks ago

dlubitz commented 2 weeks ago

… as this is not available anymore

bwaidelich commented 2 weeks ago

I guess this is good to go, but I don't understand what

this is not available anymore

means? Wouldn't this fix calls to Node::getNodeType() if it existed in some legacy code?

dlubitz commented 2 weeks ago

Yes, but it was rewritten to $node->nodeType and we don't have this property anymore on the node

kitsunet commented 2 weeks ago

And there isn't even a direct way from Node to NodeType anymore (without additional dependencies that is)

dlubitz commented 2 weeks ago

Yeah, there might be a way to rector this, but I just wanted to remove this wrong migration as it would lead to even more confusion.