search

neos / setup

An extensible setup tool for Flow based applications
MIT License
6 stars 15 forks source link

BUGFIX: Prevent Fatal Error in Setup #13

Closed bwaidelich closed 8 years ago

bwaidelich commented 8 years ago

This is a hotfix for a regression introduced with https://github.com/neos/flow-development-collection/pull/499.

Background: The latest Http\RequestHandler of Flow internally uses the ComponentChain to determine the current Request/Response.

This package uses a specialized handler which doesn't rely on the ComponentChain leading to a Fatal Error.

aertmann commented 8 years ago

needs to go into the 2.0 branch right?

bwaidelich commented 8 years ago

needs to go into the 2.0 branch right?

I'm not sure, 2.0 is used in Neos 2.0+ and the fix is only required for Neos 2.3.x. I guess we should probably create a 2.3 branch in the setup and apply it there!?

albe commented 8 years ago

The evils of inheritance... Makes sense, but be aware that the $request and $response properties will also be removed with 4.0 - so maybe already copy them over

bwaidelich commented 8 years ago

be aware that the $request and $response properties will also be removed with 4.0

That's news to me. Is that documented somewhere or is there a PR for this?

Anyways, I rather merge this now to fix the fatal. I'd suggest to merge it into master and then create a branch 2.3 and require that in the affected distributions. Does that make sense?

albe commented 8 years ago

Is that documented somewhere or is there a PR for this?

https://github.com/neos/flow-development-collection/pull/500

aertmann commented 8 years ago

@bwaidelich: I'd rather avoid a separate version if it can be done in backwards compatible way, which this seems to be..

and then if we need changes for Flow 4.x it probably makes sense to release a 2.1 or 3.0 of setup

bwaidelich commented 8 years ago

I messed up the rebase, see #28