search

neos / setup

An extensible setup tool for Flow based applications
MIT License
6 stars 15 forks source link

FEATURE: Group write permission check #38

Closed wexi79 closed 1 year ago

wexi79 commented 7 years ago

Added a method that creates a test folder into the Flow root path, creates a test file into the folder and checks that the created file has write permissions for group. Test file and folder are removed after the check, method returns true if group has write permission and false if not.

If group write fails, an error message with instructions is displayed.

wexi79 commented 7 years ago

This could be extended to checking all the other permissions of the files created too, if needed.

wexi79 commented 7 years ago

@kitsunet for some reason I can't request reviewers for this PR, but could you look at this?

wexi79 commented 7 years ago

@kdambekalns what do you mean "remove alignments"? I had to format the code in that way to get it to pass the automatic styling check...

kdambekalns commented 7 years ago

Oh well. Then StyleCI is using default settings…

There should be a .styleci.yml similar to https://github.com/neos/neos-development-collection/blob/master/.styleci.yml

wexi79 commented 7 years ago

The Data folder is created (by the setfilepermissions script) under FLOW_PATH_ROOT so what we actually do is test that we can create a similar folder and files into it with the correct permissions.

wexi79 commented 7 years ago

So basically we are testing that the cli user can access all files and folders in the Neos installation directory, is there something that the cli user should not be able to access in a setup where the cli user has no sudo rights but the initial installation is done by a sysadmin user?

mhsdesign commented 1 year ago

superseded by rewrite in version 6