search

neos / swiftmailer

A Flow package for easy use of SwiftMailer
MIT License
14 stars 18 forks source link

TASK: Update to use swiftmailer/swiftmailer version 6 #14

Closed kdambekalns closed 5 years ago

kdambekalns commented 5 years ago

💀 This has not been tested yet…

kdambekalns commented 5 years ago

✅ Works for me with LoggingTransport and MboxTransport now.

daniellienert commented 5 years ago

Uuuh, what have I done :/ I tested it post-merge thoroughly. And the default Swift transport types like Swift_SmtpTransport are not working anymore as they are not implementing the Neos\SwiftMailer\TransportInterface

@kdambekalns why did you add the interface checks: https://github.com/neos/swiftmailer/pull/14/files#diff-e2bee996df2ca8c9e00358deaa5830efR47 and https://github.com/neos/swiftmailer/pull/14/files#diff-e2bee996df2ca8c9e00358deaa5830efR57. Just to have the return type annotation?

If I remove the checks and the return type annotation, it works again.

kdambekalns commented 5 years ago

Yes, added the return type and then added the checks. But obviously that doesn't make sense, since that interface is our own…