neoteknic / Phue

Philips Hue client for PHP - fork by Neoteknic, extra features - soon new Entertainment API support
Other
13 stars 5 forks source link

Fix the 3 missing UnitTests ColorConversion - brightness #16

Open Chris53897 opened 2 years ago

Chris53897 commented 2 years ago

There are actual 3 UnitTests that are failing. https://github.com/neoteknic/Phue/runs/8056721561?check_suite_focus=true

These are all linked to the new option $bri (brightness) https://github.com/neoteknic/Phue/blob/master/library/Phue/Helper/ColorConversion.php#L74

@neoteknic Can you please fix these as i do not know what the expected output is with the new variable? But with the default value (null?) the result should have the same result as the original PhpUnit tests.