search

neothematrix / noip-renew

Auto renew (confirm) noip.com free hosts
https://hub.docker.com/r/moebiuss/noip-renew
Apache License 2.0
54 stars 20 forks source link

Change log level to 2 in line 13. #9

Closed benyjr closed 2 years ago

benyjr commented 2 years ago

Running: `/usr/local/bin/noip-renew-myusername.sh /var/log/noip-renew/myusername fails while running: '/usr/local/bin/noip-renew-myusername.sh succeeds. @peteakalad determined that log level 2 adds enough delay for the page loads to work.

Angel0ffDeath commented 2 years ago

@benyjr Last comment is correct and I already proposed eventual solution. Can you check "sleeps with proper wait events #10" and eventually make the changes, test it and share the results?

benyjr commented 2 years ago

It will take a couple of days for me to test, but I agree we should be waiting for the page to fully load instead of adding arbitrary delays. I guess we should close this commit in favour of #10?

Angel0ffDeath commented 2 years ago

We can close it always, but still not solved.... Let it remain. And if you have time to test my eventual solution - will appreciate that.... Not so much time for testing (I know how to write the code - few minutes, ,but don't have few days time to test it). This is the reason Im saying somebody else to test it... Sorry but thats the reality - must visit each day my workplace... :(

Angel0ffDeath commented 2 years ago

@benyjr Fully solved in my new PR. Will appreciate your test results. However I also recommend debuglevel to be 2 (see my explanation under PR) although now cronjob will work correct even with debuglevel 0

benyjr commented 2 years ago

Closing this PR since #10 addresses the issue.