neotheprogramist / cairo-webauthn

Cairo verification of webauthn authentication credentials
GNU General Public License v3.0
0 stars 0 forks source link

Feat/4/6 Remove old files #47

Open piniom opened 9 months ago

piniom commented 9 months ago

After the migration to property based testing I've removed all the old and redundant stuff. I've also made small adjustments to the readme to reflect recent changes.

glihm commented 9 months ago

Overall it looks good, great work on that @ThePinion!

Some feedback:

  1. Seems like part of the setup is missing in the README about the devnet, following only the README I can't get the test suite passing (some outputs at the end of the comment). Or do we want to test everything with Katana now?
  2. We should consider adding a CI for that, in order to ensure automated testing and checks. Can be done in subsequent PR though.
   webauthn_session::tests::signature_deserialization::test_session - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
---- tests::runners_test::test_devnet_runner stdout ----
thread 'tests::runners_test::test_devnet_runner' panicked at crates/account_sdk/src/tests/runners/devnet_runner.rs:44:14:
failed to start subprocess: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tests::webauthn::test_set_webauthn_public_key stdout ----
thread 'tests::webauthn::test_set_webauthn_public_key' panicked at crates/account_sdk/src/tests/runners/devnet_runner.rs:44:14:
failed to start subprocess: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- tests::webauthn::test_verify_webauthn_execute stdout ----
thread 'tests::webauthn::test_verify_webauthn_execute' panicked at crates/account_sdk/src/tests/runners/devnet_runner.rs:44:14:
failed to start subprocess: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- tests::webauthn::test_verify_webauthn_explicit stdout ----
thread 'tests::webauthn::test_verify_webauthn_explicit' panicked at crates/account_sdk/src/tests/runners/devnet_runner.rs:44:14:
failed to start subprocess: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- tests::erc20_methods_test::test_transfer stdout ----
thread 'tests::erc20_methods_test::test_transfer' panicked at crates/account_sdk/src/tests/erc20_methods_test.rs:52:10:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_invalid_proof stdout ----
thread 'tests::session::test_session_invalid_proof' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::deployment_test::test_deploy stdout ----
thread 'tests::deployment_test::test_deploy' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_invalid_signature stdout ----
thread 'tests::session::test_session_invalid_signature' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_valid stdout ----
thread 'tests::session::test_session_valid' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_compute_proof stdout ----
thread 'tests::session::test_session_compute_proof' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::stark_pair_auth_test::test_authorize_execute stdout ----
thread 'tests::stark_pair_auth_test::test_authorize_execute' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_compute_root stdout ----
thread 'tests::session::test_session_compute_root' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::deployment_test::test_deploy_and_call stdout ----
thread 'tests::deployment_test::test_deploy_and_call' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::deployment_test::test_declare stdout ----
thread 'tests::deployment_test::test_declare' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_many_allowed stdout ----
thread 'tests::session::test_session_many_allowed' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))

---- tests::session::test_session_revoked stdout ----
thread 'tests::session::test_session_revoked' panicked at crates/account_sdk/src/deploy_contract/declaration.rs:79:14:
called `Result::unwrap()` on an `Err` value: Provider(StarknetError(ContractNotFound))
piniom commented 9 months ago

Yup, thank you for the feedback. There was some back and forth about which network backend we should use hence the problems. I'll see what's needed and update the readme accordingly. Regarding the CI, we will need a dedicated docker build containing all the non-cargo dependencies. Apart from enabling the CI this should also help with configuration problems you described. Do you see it similarly or have I missed something?

piniom commented 8 months ago

@glihm I've included the reacent changes in main. Would you mind checking if the issues you've mentioned are resolved?