neovide / neovide

No Nonsense Neovim Client in Rust
https://neovide.dev
MIT License
13.06k stars 532 forks source link

Itatic not working #955

Closed ray-x closed 10 months ago

ray-x commented 3 years ago

Describe the bug I tried different font set with Itatic, none of them work.

To Reproduce Steps to reproduce the behavior:

  1. set guifont=VictorMono\ Nerd\ Font:h18
  2. use a colorscheme has itatic
  3. add comment
  4. See error image

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Please run neovide --log and paste the contents of the .log file here: neovide_rCURRENT.log

Additional context Add any other context about the problem here.

zoomlogo commented 3 years ago

Do you have the italic version of the Victor Mono? Does it work in a terminal?

ray-x commented 3 years ago

Yes. Italic loads correctly in kitty, also autoloaded in goneovim

huuson235 commented 3 years ago

I have the same problem on windows. I use Fira code NF.

zoomlogo commented 3 years ago

I have the same problem on windows. I use Fira code NF.

Fira Code doesn't have italics right?

LollipopFt commented 3 years ago

Fira Code doesn't have italics right?

it does.

LollipopFt commented 3 years ago

windows: using fira code, terminal and goneovim has italics, while neovide does not.

dineshKumar777 commented 2 years ago

@ray-x I downloaded victormono NF from https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/VictorMono/Regular/complete But italics not working in nvim-qt itself.. But at the same time normal VictorMono font displayed with Italics.

Can you build latest and give it a try. !!

ray-x commented 2 years ago

VictorMono still not working. Also tried GoMono NF and I saw this after I set guifont = GoMono\ Nerd\ Font:h18

image

Seems it reset font to itatic only.

dineshKumar777 commented 2 years ago

@ray-x baseline is nvim-qt.. pls verify whether italics are working in nvim-qt !

ray-x commented 2 years ago

nvim-qt Itatic supported If I run Guifont The result is VictorMono Nerd Font:h18

fredizzimo commented 10 months ago

I'm pretty sure this is fixed, but please re-open if it isn't