search

neovim / doc

Generated documentation and reports
neovim.github.io/doc/
Apache License 2.0
34 stars 13 forks source link

Invoking search on a help page shifts the whole content to the left #56

Closed VitGottwald closed 5 months ago

VitGottwald commented 6 months ago

Fist of all great job with the docs site and search!

I just tried it for the first time and tried searching and noticed a small glitch.

When I go to a doc page, for example https://neovim.io/doc/user/undo.html#undo-commands and I press CMD+K to invoke the search functionality, the whole content shifts to the right. After closing the search dialog, the content shifts back to the left

Untitled Untitled2

For some reason this does not happen on the main page https://neovim.io/doc/ .

justinmk commented 6 months ago

Patch welcome. Surely with all the web devs out there, someone could help with this?

Bashamega commented 5 months ago

Hello:) I have tested it on my windows computer and it worked.

justinmk commented 5 months ago

Yeah, I can't reproduce this. I assume it was fixed by one of the recent CSS changes.

VitGottwald commented 5 months ago

Just tried it and it on https://neovim.io/doc/user/undo.html#undo-commands and I can reproduce it.

justinmk commented 5 months ago

Well I can't, so without a PR this is wontfix

VitGottwald commented 5 months ago

It is best visible with viewport width over 1200px. For smaller width the content of the second grid column with navigation shifts.

I am able to consistently reproduce it on Chrome, Safari, and Firefox.

It is apparently caused by .DocSearch--active class on body when the search is open. Removing the class or the rule overflow: hidden !important; it contains fixes the issue.