neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
565 stars 36 forks source link

api: add nvim_win_hide #110

Closed glepnir closed 3 years ago

glepnir commented 3 years ago

cc @zchee

codecov[bot] commented 3 years ago

Codecov Report

Merging #110 (422e001) into master (ee5cbe9) will decrease coverage by 0.0%. The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #110     +/-   ##
========================================
- Coverage    63.2%   63.2%   -0.1%     
========================================
  Files          14      14             
  Lines        2085    2087      +2     
========================================
  Hits         1319    1319             
- Misses        631     633      +2     
  Partials      135     135             
Flag Coverage Δ
linux-1.14 63.1% <0.0%> (-0.1%) :arrow_down:
linux-1.15 63.1% <0.0%> (-0.1%) :arrow_down:
linux-1.16 63.1% <0.0%> (+<0.1%) :arrow_up:
macos-1.14 63.1% <0.0%> (-0.1%) :arrow_down:
macos-1.15 63.1% <0.0%> (-0.1%) :arrow_down:
macos-1.16 63.1% <0.0%> (-0.1%) :arrow_down:
windows-1.14 62.4% <0.0%> (+<0.1%) :arrow_up:
windows-1.15 62.4% <0.0%> (-0.1%) :arrow_down:
windows-1.16 62.4% <0.0%> (-0.1%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nvim/api.go 38.4% <0.0%> (-0.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee5cbe9...422e001. Read the comment docs.

zchee commented 3 years ago

@glepnir Thanks for PR. but, I developed on #109, and needs testcase both PRs. If you can write testcase for nvim_hide_win, I'll fix my PR about exclude nvim_hide_win. What do you think about it?

glepnir commented 3 years ago

sure write it tomorrow

zchee commented 3 years ago

@glepnir any progress?