search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
561 stars 37 forks source link

nvim: fix ExitCode() #154

Closed akiyosi closed 1 year ago

akiyosi commented 1 year ago

*ProcessState.ExitCode() return -1 if the process hasn't exited. This PR waits for the exit of the process to get the exit code correctly.

codecov[bot] commented 1 year ago

Codecov Report

Merging #154 (f2b25b7) into main (8a0d470) will increase coverage by 0.0%. The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main    #154   +/-   ##
=====================================
  Coverage   82.5%   82.5%           
=====================================
  Files         14      14           
  Lines       3122    3120    -2     
=====================================
  Hits        2577    2577           
+ Misses       545     543    -2
Flag Coverage Δ
linux-1.17-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
linux-1.18-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
linux-1.19-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
macos-1.17-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
macos-1.18-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
macos-1.19-stable 82.5% <0.0%> (+<0.1%) :arrow_up:
windows-1.17-stable 81.7% <0.0%> (+<0.1%) :arrow_up:
windows-1.18-stable 81.7% <0.0%> (+<0.1%) :arrow_up:
windows-1.19-stable 81.7% <0.0%> (+<0.1%) :arrow_up:
Impacted Files Coverage Δ
nvim/nvim.go 79.5% <0.0%> (+0.4%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zchee commented 1 year ago

@akiyosi Thanks! I'll merge it.