search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
561 stars 37 forks source link

Set --embed flag by default to avoid hanging on RPC calls #161

Closed 9Y5 closed 1 year ago

9Y5 commented 1 year ago

Identified that missing --embed flag was causing RPC calls to nvim_exec_lua to hang. See #155

Changes:

  1. Adjusted the implementation to set --embed flag by default in the nvim.NewChildProcess function to ensure a natural default to allow RPC calls to function correctly.
  2. Provided an option to override the default behavior and disable --embed by setting the nvim.ChildProcessDisableEmbed() option.

Close: #104

codecov[bot] commented 1 year ago

Codecov Report

Merging #161 (3835815) into main (fe20a78) will increase coverage by 0.0%. The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #161   +/-   ##
=====================================
  Coverage   83.2%   83.3%           
=====================================
  Files         14      14           
  Lines       3116    3132   +16     
=====================================
+ Hits        2594    2610   +16     
  Misses       522     522
Flag Coverage Δ
linux-1.18-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
linux-1.18-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
linux-1.19-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
linux-1.19-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
linux-1.20-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
linux-1.20-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.18-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.18-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.19-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.19-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.20-nightly 83.3% <100.0%> (+<0.1%) :arrow_up:
macos-1.20-stable 83.3% <100.0%> (+<0.1%) :arrow_up:
windows-1.18-nightly 82.5% <100.0%> (+<0.1%) :arrow_up:
windows-1.18-stable 82.5% <100.0%> (+<0.1%) :arrow_up:
windows-1.19-nightly 82.5% <100.0%> (+<0.1%) :arrow_up:
windows-1.19-stable 82.5% <100.0%> (+<0.1%) :arrow_up:
windows-1.20-nightly 82.5% <100.0%> (+<0.1%) :arrow_up:
windows-1.20-stable 82.5% <100.0%> (+<0.1%) :arrow_up:
Impacted Files Coverage Δ
nvim/nvim.go 79.8% <100.0%> (+0.9%) :arrow_up:
zchee commented 1 year ago

@9Y5 @justinmk Failed test seems flaky. I was re-run gha.