search

neovim / go-client

Nvim Go client
https://pkg.go.dev/github.com/neovim/go-client
Apache License 2.0
578 stars 36 forks source link

Change CI SaaS to CircleCI #39

Closed zchee closed 3 years ago

zchee commented 5 years ago

Now, Travis CI is de-fact SaaS CI. But recently, CircleCI also useful and some improved for the golang testing environment. I think would be better to switch to CircleCI, because not job pending, faster run testing or etc.

What do you think about it? AFAIK, my company was a switch to CircleCI, As a result, increase build time to x10~x30. Also, I have much knowledge of CircleCI features.

zchee commented 5 years ago

/cc @garyburd @justinmk

justinmk commented 5 years ago

Not in favor.

not job pending, faster run testing or etc. time to x10~x30.

This repo has 43 commits. Those problems are very, very far away from the highest-leverage tasks that could be worked on here.

Neovim project has ~10 repos. If every repo uses a different CI, that increases friction for little benefit.

justinmk commented 5 years ago

A high-leverage task, for example, would be: https://github.com/neovim/go-client/issues/29 . It's high-leverage because the benefit:cost ratio is very high.

The benefit:cost ratio of switching CI is very low.

zchee commented 5 years ago

@justinmk Ah, actually, I don't like TravisCI pending time. CircleCI is almost haven't pending time. That's why I suggest CircleCI. For example(Currently, it's failed...), but CircleCI can following tasks. https://circleci.com/workflow-run/3f29a06e-0b01-45c6-aadf-a632a424559a

But, Neovim org using TravisCI is org spec? If so, I respect it. Feel free to close this issue.

justinmk commented 5 years ago

It's not an org spec. But there should be a good reason to change things. Changing CI has a cost. Is the cost worth the benefit? Is it the highest-leverage task that could be worked on?

zchee commented 5 years ago

@justinmk

It's not an org spec. But there should be a good reason to change things. Changing CI has a cost. Is the cost worth the benefit? Is it the highest-leverage task that could be worked on?

Hm, OK. You're correct. So, I try to CircleCI setup to my forked https://github.com/zchee/neovim-go-client repository. If you like it, accept it. What this plan?

justinmk commented 5 years ago

@zchee What do you think about https://sourcehut.org/ ? We are considering this for Nvim core repo as well.

justinmk commented 4 years ago

GitHub actions probably makes the most sense for this repo, rather than a third party.

https://github.com/neovim/neovim-ruby/pull/62

zchee commented 4 years ago

@justinmk make sense. I'll send PR which use the GitHub action.

zchee commented 4 years ago

@justinmk but I didn't repo owner, so can't set secrer env. any idea?

justinmk commented 4 years ago

you are on the "golang" team, and all members in that team have "Admin" role on this repo. There is no "repo owner" role...

can you access this page: https://github.com/neovim/go-client/settings

Else contact me and I can create the secret at https://github.com/neovim/go-client/settings/secrets or anything else that needs to be done.

zchee commented 4 years ago

@justinmk Ah! I'd mistaken. I can see that URL. Thanks :D

zchee commented 3 years ago

We switched to GitHub Actions. close.